Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: run tests even if os.cpus() fails #9616

Closed
wants to merge 1 commit into from
Closed

test: run tests even if os.cpus() fails #9616

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Currently if the os.cpus() call fails every test will fail. As there is
already a test for os.cpus(), the other tests should run even if the
os.cpus() call fails.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 15, 2016
bnoordhuis
bnoordhuis reviewed Nov 15, 2016
View reviewed changes
test/common.js
@@ -32,7 +32,7 @@ exports.isOSX = process.platform === 'darwin';
exports.enoughTestMem = os.totalmem() > 0x40000000; /* 1 Gb */

const cpus = os.cpus();
exports.enoughTestCpu = cpus.length > 1 || cpus[0].speed > 999;
exports.enoughTestCpu = cpus != undefined && (cpus.length > 1 || cpus[0].speed > 999);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnoordhuis updated, PTAL.

@gibfahn
Copy link
Member

gibfahn commented Nov 15, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4847/

cjihrig
cjihrig reviewed Nov 15, 2016
View reviewed changes
test/common.js
@@ -32,7 +32,8 @@ exports.isOSX = process.platform === 'darwin';
exports.enoughTestMem = os.totalmem() > 0x40000000; /* 1 Gb */

const cpus = os.cpus();
exports.enoughTestCpu = cpus.length > 1 || cpus[0].speed > 999;
exports.enoughTestCpu = cpus != undefined &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using Array.isArray(cpus) here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc/ @Trott

cjihrig
cjihrig approved these changes Nov 15, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with an optional tiny nit.

@BethGriggs
test: run tests even if os.cpus() fails
a3d5d4b 
Currently if the os.cpus() call fails every test will fail. As there is
already a test for os.cpus(), the other tests should run even if the
os.cpus() call fails.
mhdawson
mhdawson approved these changes Nov 15, 2016
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gibfahn
Copy link
Member

gibfahn commented Nov 15, 2016 •
edited
Loading

CI the second: https://ci.nodejs.org/view/Node.js/job/node-test-pull-request/4854/

EDIT: CI was good except for this inspector test failure on windows (which I'm pretty sure is unrelated):

Inspector windows failure:

not ok 302 inspector/test-inspector # TODO : Fix flaky test
  ---
  duration_ms: 1.68
  severity: flaky
  stack: |-
    [err] Debugger listening on port 9229.
    [err] Warning: This is an experimental feature and could change at any time.
    [err] To start debugging, open the following URL in Chrome:
    [err]     chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=127.0.0.1:9229/9c5c9dc1-7aa4-4b2e-a926-c350559e4b44
    [err] 
    [test] Verifying debugger stops on start (--debug-brk option)
    [test] Setting a breakpoint and verifying it is hit
    [out] A message 5
    [out] 
    [test] Verify we can read current application state
    [test] Verify sending and receiving UTF8 characters
    [out] טֶ字и
    [out] 
    [test] Verify node waits for the frontend to disconnect
    [out] Outputed message #1
    [out] 
    [err] Debugger attached.
    [err] Waiting for the debugger to disconnect...
    [err] 
    [test] Connection terminated
    Error: read ECONNRESET
        at exports._errnoException (util.js:1022:11)
        at TCP.onread (net.js:572:26)
  ...

gibfahn pushed a commit that referenced this pull request Nov 18, 2016
@BethGriggs @gibfahn
test: run tests even if os.cpus() fails
0619896 
Currently if the os.cpus() call fails every test will fail. As there is
already a test for os.cpus(), the other tests should run even if the
os.cpus() call fails.

PR-URL: #9616

Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn
Copy link
Member

gibfahn commented Nov 18, 2016

Landed in 0619896

@gibfahn gibfahn closed this Nov 18, 2016
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@BethGriggs @addaleax
test: run tests even if os.cpus() fails
776d291 
Currently if the os.cpus() call fails every test will fail. As there is
already a test for os.cpus(), the other tests should run even if the
os.cpus() call fails.

PR-URL: #9616

Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@BethGriggs @addaleax
test: run tests even if os.cpus() fails
333e5d1 
Currently if the os.cpus() call fails every test will fail. As there is
already a test for os.cpus(), the other tests should run even if the
os.cpus() call fails.

PR-URL: nodejs#9616

Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@BethGriggs @MylesBorins
test: run tests even if os.cpus() fails
c63f3af 
Currently if the os.cpus() call fails every test will fail. As there is
already a test for os.cpus(), the other tests should run even if the
os.cpus() call fails.

PR-URL: #9616

Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
@BethGriggs BethGriggs deleted the pr-common-test-cpus branch February 21, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@BethGriggs @gibfahn @bnoordhuis @jasnell @evanlucas @cjihrig @mhdawson @MylesBorins @addaleax @nodejs-github-bot