Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo e.g., => e.g. doc/dns.md #9563

Closed
wants to merge 1 commit into from
Closed

doc: fix typo e.g., => e.g. doc/dns.md #9563

wants to merge 1 commit into from

Conversation

dorako321
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

fix typo e.g., => e.g.

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Nov 12, 2016
@dorako321 dorako321 changed the title doc: fix typo e.g., => e.g. doc: fix typo e.g., => e.g. doc/dns.md Nov 12, 2016
@yosuke-furukawa
Copy link
Member

please check your comment is followed commit guideline.

addaleax
addaleax approved these changes Nov 12, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

@dorako321 Your git name in this commit is written in Japanese. It might be garbage characters in some terminals. Your screen name on your github profile is in English so do you mind to change your git name of this commit into English?

@dorako321
Copy link
Contributor Author

@shigeki I fixed it. thanks.

shigeki pushed a commit that referenced this pull request Nov 13, 2016
@dorako321 @shigeki
doc: fix typo e.g., => e.g.
195989d 
Fixes: nodejs/code-and-learn#58
PR-URL: #9563
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

Thanks. Landed in 195989d.
Congrats on your first contribution to Node.

@shigeki shigeki closed this Nov 13, 2016
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@dorako321 @addaleax
doc: fix typo e.g., => e.g.
d83cb48 
Fixes: nodejs/code-and-learn#58
PR-URL: #9563
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@dorako321 @MylesBorins
doc: fix typo e.g., => e.g.
aca0ede 
Fixes: nodejs/code-and-learn#58
PR-URL: #9563
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@dorako321 @MylesBorins
doc: fix typo e.g., => e.g.
c286f57 
Fixes: nodejs/code-and-learn#58
PR-URL: #9563
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@dorako321 @MylesBorins
doc: fix typo e.g., => e.g.
29ce0cc 
Fixes: nodejs/code-and-learn#58
PR-URL: #9563
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@dorako321 @MylesBorins
doc: fix typo e.g., => e.g.
7b9f70f 
Fixes: nodejs/code-and-learn#58
PR-URL: #9563
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@shigeki shigeki shigeki approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dorako321 @yosuke-furukawa @shigeki @silverwind @addaleax @lpinca @MylesBorins @nodejs-github-bot