doc: add the diagnostics team to cc for async_wrap #9471
Conversation
addaleax
added
the
meta
|
LGTM |
|
/cc @nodejs/diagnostics |
|
LGTM also |
|
LGTM |
|
I feel like that group has far more people than actually know in detail about it, maybe a separate team is more appropriate? (Also I guess I should be joining the Diagnostics WG...) |
Agreed. But isn't the list more about who to cc for issues, than who to cc for PR reviews? There are a lot of people in @nodejs/diagnostics who are |
|
@AndreasMadsen That does expose some ambiguity, but I originally made this with two things in mind:
General discussion is imo a bit more high level and idk where to put that exactly. |
|
@Fishrock123 I see. If the list is for PR reviews and similar then @nodejs/diagnostics is definitely too board. |
|
@AndreasMadsen so it is just you and @trevnorris then? |
|
Nit: Except for the platform wildcard entry at the bottom, everything else in the list is in alphabetical (or at least alphabetical-ish) order, so perhaps this new entry should be placed alphabetically as well? |
|
@addaleax I think there are others. Maybe @Fishrock123 and @Qard? |
|
I think @trevnorris, @AndreasMadsen, and myself are probably the ones who best understand the implementation right now. |
addaleax
force-pushed
the
who-to-cc-in-issues-async_wrap
branch
from
15ba013
to
b6adbd3
Compare
|
I’ve updated this with @trevnorris, @AndreasMadsen, @Fishrock123, @Qard and tried to address @Trott’s nit (which may have failed because I am not sure what exactly is supposed to be ordered alphabetically here) |
|
Does anyone in @nodejs/diagnostics specifically object to getting notifications about async_wrap stuff? I mean, even if they aren't experts on the subject, I feel like basically everyone in the working group would have some interest in at least being notified of the developments relating to async_wrap. |
|
@Qard I'd love to get notifications on this |
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: nodejs#9467 (comment)
addaleax
force-pushed
the
who-to-cc-in-issues-async_wrap
branch
from
b6adbd3
to
d93c0f8
Compare
|
@Qard Okay, I’ve switched this back to @nodejs/diagnostics. I guess we can still update the doc to be more selective if it turns out that this is too noisy. |
|
Landed in 62eee49 |
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Josh Gavant <[email protected]>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Josh Gavant <[email protected]>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: nodejs#9467 (comment) PR-URL: nodejs#9471 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Josh Gavant <[email protected]>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Josh Gavant <[email protected]>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Josh Gavant <[email protected]>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Josh Gavant <[email protected]>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Josh Gavant <[email protected]>
Add the nodejs/diagnostics team to the “Who to CC in issues” list
as the maintainers of
async_hooks.Ref: #9467 (comment)