Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: change == to === in linkedlist #9362

Closed
wants to merge 1 commit into from
Closed

lib: change == to === in linkedlist #9362

wants to merge 1 commit into from

Conversation

jedireza
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib, timers

Description of change

change == to === in linkedlist

Also removed an old TODO comment that likely won't happen anymore.

@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Oct 29, 2016
@Trott
Copy link
Member

Trott commented Oct 29, 2016

LGTM if CI is ✅

@Trott
Copy link
Member

Trott commented Oct 29, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4738/

@mscdex
Copy link
Contributor

mscdex commented Oct 29, 2016

LGTM

1 similar comment
@bengl
Copy link
Member

bengl commented Oct 29, 2016

LGTM

@Trott
Copy link
Member

Trott commented Oct 29, 2016

GREEN! CI IS GREEN! SECOND ONE IN A ROW!

@Fishrock123
Copy link
Contributor

I think we should change the // TODO to a more helpful comment but of the same general nature

jasnell
jasnell approved these changes Oct 30, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cjihrig
cjihrig approved these changes Oct 31, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change on line 19 LGTM. I don't know why the comment changed.

@jedireza
Copy link
Contributor Author

Apologies if the comment removal is a noisy change. I was working with @Trott and he mentioned we could remove the comment as the todo was not likely to happen.

Admittedly I'm not very familiar with this part of the code base. I'm happy to resolve by;

  • putting the comment back
  • rewording it like @Fishrock123 mentioned (I would need help with that)
  • fixing the todo (I would need help understanding the intuitive older items at "prev")

@Fishrock123
Copy link
Contributor

I don't think fixing the TODO is viable because it is effectively public API. A comment should remain that the property names are opposite of what would be typically logical.

@Trott
Copy link
Member

Trott commented Oct 31, 2016

Agree 100% with @Fishrock123: The TODO should be removed because it isn't feasible. But a comment should remain highlighting that the names of the properties are the opposite of what you would intuitively expect.

@jedireza
lib: change == to === in linkedlist
92ebcef 
Also removed a TODO comment that is no longer viable and left a note
about the potentially confusing property naming convention for future
readers.
@jedireza
Copy link
Contributor Author

I pushed edits updating the comment and commit message.

@silverwind
Copy link
Contributor

Thanks! Landed in 62d8134.

@silverwind silverwind closed this Nov 1, 2016
silverwind pushed a commit that referenced this pull request Nov 1, 2016
@jedireza @silverwind
lib: change == to === in linkedlist
62d8134 
Also removed a TODO comment that is no longer viable and left a note
about the potentially confusing property naming convention for future
readers.

PR-URL: #9362
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@jedireza jedireza deleted the linkedlist-triple-equals branch November 2, 2016 03:43
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@jedireza @evanlucas
lib: change == to === in linkedlist
5bfefa6 
Also removed a TODO comment that is no longer viable and left a note
about the potentially confusing property naming convention for future
readers.

PR-URL: #9362
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@jedireza
lib: change == to === in linkedlist
a178abf 
Also removed a TODO comment that is no longer viable and left a note
about the potentially confusing property naming convention for future
readers.

PR-URL: #9362
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.