Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove dangling eslint symlink #9299

Merged
merged 1 commit into from
Oct 27, 2016
Merged

tools: remove dangling eslint symlink #9299

merged 1 commit into from
Oct 27, 2016

Conversation

sam-github
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

@Trott

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 26, 2016
@sam-github sam-github added tools Issues and PRs related to the tools directory. and removed tools Issues and PRs related to the tools directory. labels Oct 26, 2016
Trott
Trott approved these changes Oct 26, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not sure what the best way to keep this from happening going forward would be. I guess step one is just more awareness and people calling it out on PRs that update ESLint...

@sam-github
Copy link
Contributor Author

@Trott I'm not sure either. How did you create the eslint you committed? What was your sequence? We could probably figure out one that works and document in a README somewhere. Or in the next commit message. You put some effort into your commit to say what you did, but just at a high level.

@jasnell
Copy link
Member

jasnell commented Oct 26, 2016

btw, this one is trivial enough that it shouldn't need to wait the 48 hours to land.

@sam-github
tools: remove dangling eslint symlink
de24c45 
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#9299
@sam-github sam-github merged commit de24c45 into nodejs:master Oct 27, 2016
@sam-github
Copy link
Contributor Author

sam-github commented Oct 27, 2016 •
edited by MylesBorins
Loading

Landed in de24c45

(edited by @thealphanerd original message accidentally included the issue number not commit)

@sam-github sam-github deleted the rm-eslint-invalid-symlinks branch October 27, 2016 16:39
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@sam-github @evanlucas
tools: remove dangling eslint symlink
c23ece7 
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #9299
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2016
@sam-github
tools: remove dangling eslint symlink
1e6d788 
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #9299
MylesBorins pushed a commit that referenced this pull request Nov 17, 2016
@sam-github
tools: remove dangling eslint symlink
f9baa11 
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #9299
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
@sam-github @MylesBorins
tools: remove dangling eslint symlink
07d34f9 
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #9299
This was referenced Nov 22, 2016
Merged
Merged
@sam-github sam-github mentioned this pull request Jan 12, 2017
Closed
3 tasks
sam-github added a commit that referenced this pull request Jan 12, 2017
@sam-github
eslint: remove dangling eslint symlink
0c8cfd4 
Reapplication of #9299 since the
symlink was re-added in f44969a.

PR-URL: #10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@sam-github @italoacasas
eslint: remove dangling eslint symlink
870b45b 
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@sam-github @italoacasas
eslint: remove dangling eslint symlink
9eb6d6b 
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@sam-github sam-github mentioned this pull request Jan 27, 2017
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
@sam-github @targos
eslint: remove dangling eslint symlink
ebd6f51 
Reapplication of #9299 since the
symlink was re-added in f44969a.

PR-URL: #10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@sam-github @italoacasas
eslint: remove dangling eslint symlink
78a495e 
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@sam-github @italoacasas
eslint: remove dangling eslint symlink
ab144b0 
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@gibfahn gibfahn mentioned this pull request Apr 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sam-github @jasnell @Trott @addaleax @cjihrig @MylesBorins @nodejs-github-bot