src: fix domains + --abort-on-uncaught-exception #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If run with --abort-on-uncaught-exception, V8 will abort the process whenever it does not see a JS-installed CatchClause in the stack. C++ TryCatch clauses are ignored. Domains work by setting a FatalException handler which is ignored when running in abort mode. This patch modifies MakeCallback to call its target function through a JS function that installs a CatchClause and manually calls _fatalException on error, if the process is both using domains and is in abort mode. Fixes: #836
|
Closing this for a second while I work out some bugs. |
|
Okay, I think this is in a better state now. |
|
Looks great, no floating patch in v8 land and the code is straightforward. |
| if (has_abort_on_uncaught_and_domains) { | ||
| Local<Value> fn = process->Get(env()->domain_abort_uncaught_exc_string()); | ||
| if (fn->IsFunction()) { | ||
| Local<Array> specialContext = Array::New(env()->isolate(), 2); |
There was a problem hiding this comment.
Minor style nit: snake_case, not camelCase.
|
LGTM with comments. V8 accepts mixed dashes and underscores in command line arguments while your patch accepts only one or the other but I don't think it matters much in practice. |
chrisdickinson
added a commit
that referenced
this pull request
Feb 25, 2015
If run with --abort-on-uncaught-exception, V8 will abort the process whenever it does not see a JS-installed CatchClause in the stack. C++ TryCatch clauses are ignored. Domains work by setting a FatalException handler which is ignored when running in abort mode. This patch modifies MakeCallback to call its target function through a JS function that installs a CatchClause and manually calls _fatalException on error, if the process is both using domains and is in abort mode. Semver: patch PR-URL: #922 Fixes: #836 Reviewed-By: Ben Noordhuis <[email protected]>
|
Merged in 0af4c9e. |
|
@chrisdickinson could this be considered semver-minor? |
|
Semver-patch. |
|
@chrisdickinson You forgot to implement the same for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If run with --abort-on-uncaught-exception, V8 will abort the process whenever it does not see a JS-installed CatchClause in the stack. C++ TryCatch clauses are ignored. Domains work by setting a FatalException handler which is ignored when running in abort mode.
This patch modifies MakeCallback to call its target function through a JS function that installs a CatchClause and manually calls _fatalException on error, if the process is both using domains and is in abort mode.
Fixes: #836
Some notes on this:
I am not a fan of how I've got the
ParseArgsstuff working – specifically, theabort_on_uncaught_exc_hangs off of the Environment object (which seems correct) but is also stored globally in a static boolean in node.cc. This is mostly out of expedience, since the environment hasn't been created yet, but I want to preserve the initial value. This feels bad, I am open to suggestions on how to make that better.This does add the overhead of one branch to all
MakeCallbackcalls. I'm not sure if there's a way to get around this, though.Currently it does not respond to changes from
require('v8').setFlagsFromString. I wanted to get a read on the approach before complicating that code.R=@trevnorris + @bnoordhuis, /cc @geek