Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: expand use of CTC issue tracker #8945

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 6, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

As the CTC grows and has representation from more time zones, we need to
embrace asynchronous decision making and rely less on the actual
meeting. This change is a proposal for that which, ironically, probably
has to be approved at a meeting.

/cc @nodejs/ctc

@Trott Trott added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. ctc-agenda labels Oct 6, 2016
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 6, 2016
[the CTC issue tracker](https://github.com/nodejs/CTC/issues). The process in
the issue tracker is:

* A CTC member opens an issue explaining the propoosal/issue and @-mentions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proposal

@@ -112,7 +107,7 @@ Typical activities of a CTC member include:
Note that CTC members are also Collaborators and therefore typically perform
Collaborator activities as well.

### CTC Meetings
### CTC Meetings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a whitespace at the end of the line?

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo what @thefourtheye pointed out.

individuals are identified by the CTC and their addition as
Collaborators is discussed during the weekly CTC meeting.
Individuals identified by the CTC as making significant and valuable
contributions are made Collaborators and given commit-access to the project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit but isn't it spelled 'commit access', no dash?

@mhdawson
Copy link
Member

mhdawson commented Oct 6, 2016

LGTM subject to comments identified by others.

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Again, with the nits addressed.

* A CTC member opens an issue explaining the propoosal/issue and @-mentions
@nodejs/ctc.
* After 72 hours, if there are two or more `LGTM`s from other CTC members and no
explicit opposition from other CTC members, then the proposal is approved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit tight for ensuring consensus imo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit tight for ensuring consensus imo

What would seem a better duration in your opinion? I chose 72 hours because that seemed like a duration for an issue on the tracker that was more likely to actually map to real consensus than a conversation at a meeting attended by maybe 10 of the CTC's 18 members. Arguably, that's not a high bar, but it's what we have now, so that's what I used as an approximate metric. Totally open to other ideas. What did you have in mind?

@jasnell
Copy link
Member

jasnell commented Oct 6, 2016

This LGTM with nits addressed.
I have been wondering if a separate ctc-review label would be useful for distinguishing between things that just require CTC review vs. things that need to be escalated to a meeting.

As the CTC grows and has representation from more time zones, we need to
embrace asynchronous decision making and rely less on the actual
meeting. This change is a proposal for that which, ironically, probably
has to be approved at a meeting.
@Trott
Copy link
Member Author

Trott commented Oct 7, 2016

Nits addressed, rebased, force pushed.

@jasnell
Copy link
Member

jasnell commented Oct 10, 2016

Does this still need to be on the ctc-agenda?

@Trott
Copy link
Member Author

Trott commented Oct 10, 2016

Does this still need to be on the ctc-agenda?

Yes.

@Trott
Copy link
Member Author

Trott commented Oct 12, 2016

It would be great if CTC folks could read the new paragraph and the bullet points and weighed in before the meeting. I'd be happy to not have to bring this to the meeting.

CTC folks who have not offered an opinion yet:

@rvagg
Copy link
Member

rvagg commented Oct 12, 2016

ctc-review might be a good idea, however it's really at the discretion of the meeting chair whether something goes on the agenda or not and some things can be left off as required.

This lgtm for now. I'm hesitant with the 72-hours two-only requirement for passing major things, but we can only see how it goes and adjust if enough of us are unhappy with the process. My main concern is simply with the workload of GitHub notifications and I'm constantly behind these days. I'll just have to make sure I tune in to nodejs/ctc tagged items!

@evanlucas
Copy link
Contributor

lgtm. I'd be +1 to a ctc-review label. I think it would make it a lot easier to see what issues need attention.

@ChALkeR
Copy link
Member

ChALkeR commented Oct 12, 2016

+1 in general, but with splitting a «CTC should take a look at this» with «this escalated to voting».

The moment when it has been escalated to voting should be clearly visible. That is probably a separate thing from ctc-review (review needed by the CTC) and ctc-agenda (consensus-seeking). ctc-vote, perhaps?

Currently ctc-review and ctc-agenda labels are present or proposed. Could we codify both of those?

Copy link

@misterdjules misterdjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

I want to echo @rvagg's hesitation on the 72 hour + 2 ctc minimum for moving things forward. Obviously this will be a case by case basis... but if something is controversial I do thing we need to have a bit of a wider consensus on it. I think a hard rule here may miss the point, but I feel we may need more time + opinions on it. I'm +1 on everything but that nit.

@ofrobots
Copy link
Contributor

LGTM w/ the same hesitation as @thealphanerd and @rvagg.

@Trott
Copy link
Member Author

Trott commented Oct 13, 2016

ctc-review might be a good idea, however it's really at the discretion of the meeting chair whether something goes on the agenda or not and some things can be left off as required.

That may be true in practice, but it is in contradiction of our GOVERNANCE.md doc which says of the CTC agenda:

The moderator and the CTC cannot veto or remove items.

@Trott
Copy link
Member Author

Trott commented Oct 13, 2016

I've created the ctc-review label. Documenting it in GOVERNANCE.md will be in a subsequent pull request.

@Trott
Copy link
Member Author

Trott commented Oct 13, 2016

I count at least 11 (and possibly as many as 14) approvals from current CTC members.

The approvals as I see it come from:

addaleax
bnoordhuis
cjihrig
evanlucas
jasnell
mhdawson
misterdjules
rvagg
shigeki
trott

There are also maybe-approvals-I'm-not-sure from:

chalker
ofrobots
thealphanerd

So I think this can land.

I'll create a ctc-agenda issue for discussion of how this is working or not working. We can probably leave that on the meeting agenda for two or three weeks. If nothing else, people can give feedback on whether 72 hours is working or not.

Trott added a commit to Trott/io.js that referenced this pull request Oct 13, 2016
As the CTC grows and has representation from more time zones, we need to
embrace asynchronous decision making and rely less on the actual
meeting. This change is a proposal for that which, ironically, probably
has to be approved at a meeting.

PR-URL: nodejs#8945
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Julien Gilli <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@Trott
Copy link
Member Author

Trott commented Oct 13, 2016

Landed in b899140. Thanks, everyone.

@Trott Trott closed this Oct 13, 2016
jasnell pushed a commit that referenced this pull request Oct 14, 2016
As the CTC grows and has representation from more time zones, we need to
embrace asynchronous decision making and rely less on the actual
meeting. This change is a proposal for that which, ironically, probably
has to be approved at a meeting.

PR-URL: #8945
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Julien Gilli <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@Trott Trott removed the ctc-agenda label Oct 20, 2016
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
As the CTC grows and has representation from more time zones, we need to
embrace asynchronous decision making and rely less on the actual
meeting. This change is a proposal for that which, ironically, probably
has to be approved at a meeting.

PR-URL: #8945
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Julien Gilli <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
As the CTC grows and has representation from more time zones, we need to
embrace asynchronous decision making and rely less on the actual
meeting. This change is a proposal for that which, ironically, probably
has to be approved at a meeting.

PR-URL: #8945
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Julien Gilli <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
This was referenced Nov 22, 2016
@Trott Trott deleted the ctc-agenda branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.