doc: ./node to node in debugger.md #8943
Conversation
nodejs-github-bot
added
debugger
doc
|
@AnnaMag could you prefix your commit message with |
There was a problem hiding this comment.
Looks good!
Generally +1 to @Fishrock123’s request (you should be able to edit the commit message using git commit --amend && git push -f, just in case). That can also be applied when merging the commit, so don’t worry about that.
|
@addaleax, @Fishrock123 Ok! next time will keep that convention in mind. |
|
Thanks! Can you prefix the commit message with |
|
LGTM. I think this is trivial enough that it does not have to wait the full 48 hours to land. |
|
@AnnaMag Hi, not sure where the second commit here is coming from, but that seems like something that should go into a different pull request? (If you have any questions, always feel free to ask, here or e.g. in #node-dev on Freenode!) |
|
@addaleax upps! I added a new commit to the same branch on my remote. |
|
@AnnaMag you can remove the wrong commit and force push, no need to close the pr. |
|
done! apologies for the confusion:) |
|
No problem, I was just surprised. I agree with @jasnell, this doesn’t need to wait 48 hours, so I’ll go ahead and merge this PR. :) |
|
Oh, by the way – your author name in this commit is given as |
|
@addaleax, I appreciate you pointing it out. I am fine with the way it is at the moment. Thanks though! |
Fixes: #8942 PR-URL: #8943 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Aye aye then! Landed this in bf0bcf4, thanks for the contribution! |
Fixes: #8942 PR-URL: #8943 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes: #8942 PR-URL: #8943 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes: #8942 PR-URL: #8943 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
doc: typo in line 123 of doc/api/debugger.md
example node calls use node, not ./node
Fixes: Examples in debugger documentation should all use global node #8942