Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump V8 patch to 84 #8851

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

MylesBorins
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

The patch should have been bumped in aafc314 but it was missed.

Ref: aafc314
Ref: #8673

@nodejs-github-bot nodejs-github-bot added v6.x v8 engine Issues and PRs related to the V8 dependency. labels Sep 29, 2016
@fhinkel
Copy link
Member

fhinkel commented Sep 29, 2016

LGTM

1 similar comment
@targos
Copy link
Member

targos commented Sep 29, 2016

LGTM

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The patch should have been bumped in aafc314 but it was missed.

Ref: nodejs@aafc314
Ref: nodejs#8673

PR-URL: nodejs#8851
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins MylesBorins merged commit 9d41e89 into nodejs:v6.x-staging Oct 4, 2016
@MylesBorins
Copy link
Contributor Author

landed in 9d41e89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants