test: updates != and var language #8764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes var to const, != to !==, and assert.equal() to assert.strict Equal()
|
LGTM if CI is OK |
cjihrig
approved these changes
Sep 25, 2016
|
I'll start landing this:
|
imyller
pushed a commit
to imyller/node
that referenced
this pull request
Sep 27, 2016
Changes var to const, != to !==, and assert.equal() to assert.strict Equal() PR-URL: nodejs#8764 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
|
landed in e5f5f3a Thank you for your effort and contribution, @nohmapp |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
Changes var to const, != to !==, and assert.equal() to assert.strict Equal() PR-URL: #8764 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Changes var to const, != to !==, and assert.equal() to assert.strict Equal() PR-URL: #8764 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Changes var to const, != to !==, and assert.equal() to assert.strict
Equal()