Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix add-on builds, partially revert 8aed9d66 #868

Closed
wants to merge 1 commit into from

Commits on Feb 17, 2015

  1. src: fix add-on builds, partially revert 8aed9d66

    Commit 8aed9d66 ("src: cleanup `Isolate::GetCurrent()`") breaks building
    add-ons because of the following:
    
        In file included from ../node_modules/nan/nan.h:27:0,
                         from ../src/binding.cc:18:
        /home/bnoordhuis/src/v1.x/src/node_object_wrap.h: In member function
        'v8::Local<v8::Object> node::ObjectWrap::handle()':
        /home/bnoordhuis/src/v1.x/src/node_object_wrap.h:39:46: error: base
        operand of '->' has non-pointer type 'v8::Persistent<v8::Object>'
             return v8::Local<v8::Object>::New(handle_->GetIsolate(),
                                               persistent());
    
    Mea culpa, I was one of the reviewers.
    bnoordhuis committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    5eca1b0 View commit details
    Browse the repository at this point in the history