Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: favor strict equality in pummel net tests #8135

Closed
wants to merge 1 commit into from
Closed

test: favor strict equality in pummel net tests #8135

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 17, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test net

Description of change

Favor strict equality checks over loose equality checks in
pummel/test-net-* tests.

@Trott
test: favor strict equality in pummel net tests
6612263 
Favor strict equality checks over loose equality checks in
pummel/test-net-* tests.
@Trott Trott added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Aug 17, 2016
@targos
Copy link
Member

targos commented Aug 17, 2016

LGTM

3 similar comments
@fhinkel
Copy link
Member

fhinkel commented Aug 17, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Aug 17, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Aug 17, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Aug 18, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/3723/

Trott added a commit that referenced this pull request Aug 19, 2016
@Trott
test: favor strict equality in pummel net tests
8ff3d61 
Favor strict equality checks over loose equality checks in
pummel/test-net-* tests.

PR-URL: #8135
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Aug 19, 2016

Landed in 8ff3d61

@Trott Trott closed this Aug 19, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@Trott @evanlucas
test: favor strict equality in pummel net tests
cc9bb34 
Favor strict equality checks over loose equality checks in
pummel/test-net-* tests.

PR-URL: #8135
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@Trott
test: favor strict equality in pummel net tests
3702f1f 
Favor strict equality checks over loose equality checks in
pummel/test-net-* tests.

PR-URL: #8135
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
test: favor strict equality in pummel net tests
2f280b6 
Favor strict equality checks over loose equality checks in
pummel/test-net-* tests.

PR-URL: #8135
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
test: favor strict equality in pummel net tests
e3669f8 
Favor strict equality checks over loose equality checks in
pummel/test-net-* tests.

PR-URL: #8135
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
@Trott Trott deleted the stricter branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @targos @fhinkel @cjihrig @jasnell @MylesBorins