Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Change straight quotes to curly quotes #811

Closed
wants to merge 1 commit into from
Closed

doc: Change straight quotes to curly quotes #811

wants to merge 1 commit into from

Conversation

oskwazir
Copy link

In an effort to improve typography in the docs single straight
quotes were changed to curly quotes wherever applicable.

The reason for using curly quotes instead of straight quotes is
explained here1

In an effort to improve typography in the docs single straight
quotes were changed to curly quotes wherever applicable.

The reason for using curly quotes instead of straight quotes is
explained here[1]
[1]: http://practicaltypography.com/straight-and-curly-quotes.html
@rvagg
Copy link
Member

rvagg commented Feb 11, 2015

The only objection I have to this is the increase in difficulty in contributing to these docs and the difficulty in keeping it consistent.

Is there a way we can script this at build time instead?

@bnoordhuis
Copy link
Member

-1 for the reason that \u2019 doesn't always render properly in terminals.

@rvagg
Copy link
Member

rvagg commented Feb 11, 2015

@bnoordhuis can you provide an example of this?

@bnoordhuis
Copy link
Member

With screen(1) over ssh, the curly quote gets mangled to a '?' character (screen's way of saying "I don't know how to display this.")

@trevnorris
Copy link
Contributor

What @bnoordhuis said. It's easier to leave text in ASCII space unless necessary.

@oskwazir
Copy link
Author

I wasn’t aware about curly quotes not rendering in some terminals. Yeah I agree too it’s better to leave text in ASCII. I’ll close this pull request.

@oskwazir oskwazir closed this Feb 12, 2015
@trevnorris
Copy link
Contributor

@TheWazir Thanks for taking the time to contribute. Hope to see you back soon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants