doc: Add fhinkel to collaborators #8052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -216,6 +216,8 @@ more information about the governance of the Node.js project, see | |||
| **Robert Jefe Lindstaedt** <[email protected]> | |||
| * [estliberitas](https://github.com/estliberitas) - | |||
| **Alexander Makarenko** <[email protected]> | |||
| * [fhinkel] (https://github.com/fhinkel) - | |||
| **Franziska Hinkelmann <[email protected]> | |||
There was a problem hiding this comment.
Looks like there's a missing ** after your name.
|
LGTM, pending nits. |
|
LGTM |
|
LGTM! |
fhinkel
added a commit
that referenced
this pull request
Aug 10, 2016
Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #8052
|
Landed in 4878e1c. |
|
🎉🎉🎉🎉 On Wed, Aug 10, 2016, 1:18 PM Franziska Hinkelmann [email protected]
|
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #8052
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 9, 2016
Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #8052
MylesBorins
pushed a commit
that referenced
this pull request
Sep 28, 2016
Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #8052
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #8052
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #8052
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Add https://github.com/fhinkel to collaborators.