Adding more specific README URLs to io.js, keeping node in too #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjacobclark
changed the title
imjacobclark
changed the title
| - [nodejs.org](http://nodejs.org/) | ||
| - [how to install node.js and npm (node package manager)](http://www.joyent.com/blog/installing-node-and-npm/) | ||
| - [list of modules](https://github.com/joyent/node/wiki/modules) | ||
| - [list of node modules](https://github.com/joyent/node/wiki/modules) |
There was a problem hiding this comment.
-1 the ecosystem should be shared :(
There was a problem hiding this comment.
Good point, agreed. I was trying to be specific to where you were being linked however it does appear to give that impression.
Fixed.
There was a problem hiding this comment.
yay, good to see your changes 🍒
Closed
| - [node community](https://github.com/joyent/node/wiki/Community) | ||
| - [io.js contributing](https://github.com/io.js/iojs/wiki/Contributing) | ||
| - [big list of all the helpful node wiki pages](https://github.com/joynet/node/wiki/_pages) | ||
| - [big list of all the helpful io.js wiki pages](https://github.com/io.js/iojs/wiki/_pages) |
There was a problem hiding this comment.
suggestion: put io.js-based resources above their node.js equivalents?
|
Closing as no longer relevant. |
jianchun
referenced
this pull request
in nodejs/node-chakracore
Dec 2, 2015
"supportsOverrideToString" was originally added to make old FastBuffer work. Buffer has long changed implementation. This is no longer used. Fix #80 Reviewed-by: @kunalspathak
jianchun
referenced
this pull request
in nodejs/node-chakracore
Dec 7, 2015
"supportsOverrideToString" was originally added to make old FastBuffer work. Buffer has long switched to TypedArray implementation. This is no longer used. Fix #80 Reviewed-by: @kunalspathak
rvagg
pushed a commit
to nodejs/TSC
that referenced
this pull request
Jun 14, 2016
PR-URL: nodejs/node#80 Reviewed-By: Rod Vagg <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the readme and created the two Wiki pages for Community and Contributing, using the CONTRIBUTING.md and the Node Community Wiki as a template.