test,vm: fix flaky test-util-sigint-watchdog #7933
Conversation
Fix parallel/test-util-sigint-watchdog by polling until the signal has definitely been received instead of just using a timeout. Fixes: nodejs#7919
addaleax
added
util
nodejs-github-bot
added
the
c++
|
CI: https://ci.nodejs.org/job/node-test-commit/4346/ |
|
The stress test was green, but one with more runs to be sure (the master stress test failed with just 1 failure/1000 runs): https://ci.nodejs.org/job/node-stress-single-test/845/nodes=freebsd10-64/ |
|
One more CI: https://ci.nodejs.org/job/node-test-pull-request/3491/ (previous CI had a failed build on FreeBSD but was otherwise clean) |
|
CI is green. Not sure who should be pinged for review on |
|
LGTM but let's get @bnoordhuis to take a look also. |
|
Bump! @bnoordhuis maybe? @cjihrig maybe? @saghul maybe? |
|
@addaleax is the first commit necessary to fix the flaky test? |
|
Sorry, I'm afraid I can't be of much help here :-S |
|
@cjihrig No, if you think that it makes reviewing a lot easier, I can leave it out. |
|
I just wanted to make sure I was understanding correctly. I don't have a strong opinion. It does seem to simplify the code a bit, but I'll defer to @bnoordhuis there. LGTM with or without the mutex change. |
|
Bump. |
|
|
|
Looks like the commit is missing a few pieces of metadata. |
|
Dang, forgot that again… fixed in a moment |
PR-URL: #7933 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fix parallel/test-util-sigint-watchdog by polling until the signal has definitely been received instead of just using a timeout. Fixes: #7919 PR-URL: #7933 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #7933 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fix parallel/test-util-sigint-watchdog by polling until the signal has definitely been received instead of just using a timeout. Fixes: #7919 PR-URL: #7933 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
@addaleax should this be backported? |
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test,util
Description of change
node_watchdog.ccandnode_watchdog.hsignal has definitely been received instead of just using a timeout.