Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: cherry-pick 43547df from V8 upstream #7863

Closed
wants to merge 1 commit into from
Closed

deps: cherry-pick 43547df from V8 upstream #7863

wants to merge 1 commit into from

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Jul 24, 2016

Checklist
  • make -j4 test (UNIX)
  • commit message follows commit guidelines
Affected core subsystem(s)

deps V8

Description of change

deps: cherry-pick 43547df from V8 upstream that fixes #6883

/cc @nodejs/v8

@fhinkel
deps: cherry-pick 43547df from V8 upstream
9df702f 
Original commit message:

  [crankshaft] Don't inline "dont_crankshaft" functions

  Crankshaft shouldn't try to inline functions it knows it can't handle.

  BUG=v8:5033

  Review-Url: https://codereview.chromium.org/2000703002
  Cr-Commit-Position: refs/heads/master@{nodejs#36417}

Fixes: nodejs#6883
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jul 24, 2016
@fhinkel fhinkel mentioned this pull request Jul 24, 2016
Closed
@mscdex mscdex added the v6.x label Jul 24, 2016
@bnoordhuis
Copy link
Member

LGTM. I'd start the CI for you but the page is timing out.

@targos
Copy link
Member

targos commented Jul 25, 2016

LGTM.
CI: https://ci.nodejs.org/job/node-test-pull-request/3397/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/235/

@fhinkel
Copy link
Member Author

fhinkel commented Jul 25, 2016

Thanks, didn't pass though.

/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/out/Release/obj.target/node/src/node_main.o: file not recognized: File truncated
collect2: error: ld returned 1 exit status

We've seen this CI problem before. Has anybody re-imaged the machine like @mhdawson suggested?

@ofrobots
Copy link
Contributor

Another attempt:
CI: https://ci.nodejs.org/job/node-test-pull-request/3411/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/239/

@fhinkel
Copy link
Member Author

fhinkel commented Jul 30, 2016

OSX and arm failed, but we don't have the output anymore.

V8 CI failed for PPC, https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=ppcbe-ubuntu1404,v8test=v8test/240/console:

ubuntu1404/v8test/v8test/deps/v8/out/ppc64.release/obj.target/tools/gyp/libv8_libplatform.a: error adding symbols: Archive has no index; run ranlib to add one
collect2: error: ld returned 1 exit status

@ofrobots
Copy link
Contributor

ofrobots commented Aug 1, 2016

Another attempt:
CI: https://ci.nodejs.org/job/node-test-pull-request/3490/
V8CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/253/

@ofrobots
Copy link
Contributor

ofrobots commented Aug 4, 2016

Power BE was the only failure in the above. Another CI (with rebasing disabled to avoid the merge conflict due to V8 version bump): https://ci.nodejs.org/job/node-test-pull-request/3525/

@ofrobots
Copy link
Contributor

ofrobots commented Aug 4, 2016 •
edited
Loading

Looks green, and LGTM. Will land later today.
EDIT: I will bump the V8 version at landing time.

ofrobots pushed a commit that referenced this pull request Aug 5, 2016
@fhinkel @ofrobots
deps: cherry-pick 43547df from V8 upstream
75b37a6 
Original commit message:

  [crankshaft] Don't inline "dont_crankshaft" functions

  Crankshaft shouldn't try to inline functions it knows it can't handle.

  BUG=v8:5033

  Review-Url: https://codereview.chromium.org/2000703002
  Cr-Commit-Position: refs/heads/master@{#36417}

Fixes: #6883
PR-URL: #7863
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: ofrobots - Ali Ijaz Sheikh <[email protected]>
@ofrobots
Copy link
Contributor

ofrobots commented Aug 5, 2016

Landed as 75b37a6 with V8 version bumped to 5.0.71.60.

@ofrobots ofrobots closed this Aug 5, 2016
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
BethGriggs pushed a commit to ibmruntimes/node that referenced this pull request Aug 18, 2016
@fhinkel @BethGriggs
deps: cherry-pick 43547df from V8 upstream
902919a 
Original commit message:

  [crankshaft] Don't inline "dont_crankshaft" functions

  Crankshaft shouldn't try to inline functions it knows it can't handle.

  BUG=v8:5033

  Review-Url: https://codereview.chromium.org/2000703002
  Cr-Commit-Position: refs/heads/master@{#36417}

Fixes: nodejs/node#6883
PR-URL: nodejs/node#7863
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Reviewed-By: targos - Michaël Zasso <[email protected]>
Reviewed-By: ofrobots - Ali Ijaz Sheikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fhinkel @bnoordhuis @targos @ofrobots @mscdex @MylesBorins @nodejs-github-bot