Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: enforce loading required modules first #7830

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 22, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools test

Description of change

Refs: #7786

@Trott Trott added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jul 22, 2016
@thefourtheye
Copy link
Contributor

thefourtheye commented Jul 22, 2016

This just checks if the required modules are loaded before any other files are loaded right?

But there shouldn't be any executable statements as well, before the common module is loaded.

@Trott
Copy link
Member Author

Trott commented Jul 22, 2016

This just checks if the required modules are loaded before any other files are loaded right?

But there shouldn't be any executable statements as well, before the common module is loaded.

Yes, good point. I'll need to fix that or someone will have to do an alternate implementation...

@Trott
Copy link
Member Author

Trott commented Jul 22, 2016

Closing as a correct implementation will probably be rather different. I'm guessing it would be a separate rule altogether...

@Trott Trott closed this Jul 22, 2016
@Trott Trott deleted the common-lint branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants