src: use RAII for mutexes and condition variables (v4.x) #7715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
c++
nodejs-github-bot
added
the
build
bnoordhuis
changed the title
|
would be good to have this mature on v6 for a bit longer before taking this in |
MylesBorins
force-pushed
the
v4.x-staging
branch
from
11da35d
to
63d94ee
Compare
|
@bnoordhuis this is going to need to be rebased one more time. Since I don't think it is going to land in v4.5.0 I think you should hold off on doing so until after the release to avoid doing it again. I'll ping you when it will be a good time |
MylesBorins
force-pushed
the
v4.x-staging
branch
from
810f29f
to
9308205
Compare
|
@bnoordhuis it is time :D |
We will be introducing many more critical sections in the upcoming multi-isolate changes, so let's make manual synchronization a thing of the past. PR-URL: nodejs#7334 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
bnoordhuis
force-pushed
the
backport-pr7334-v4.x
branch
from
834d474
to
ab9e3aa
Compare
|
Updated, PTAL. EDIT: https://ci.nodejs.org/job/node-test-pull-request/3940/ |
|
landed in efc77ec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@thealphanerd
CI: https://ci.nodejs.org/job/node-test-pull-request/3287/