Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update v8_inspector #7385

Closed
wants to merge 1 commit into from
Closed

deps: update v8_inspector #7385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions deps/v8_inspector/platform/inspector_protocol/generate-inspector-protocol-version
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
#
#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above
Expand All @@ -14,7 +14,7 @@
# * Neither the name of Google Inc. nor the names of its
# contributors may be used to endorse or promote products derived from
# this software without specific prior written permission.
#
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
Expand All @@ -28,7 +28,7 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#
# Inspector protocol validator.
#
#
# Tests that subsequent protocol changes are not breaking backwards compatibility.
# Following violations are reported:
#
Expand All @@ -39,7 +39,7 @@
# - Event has been removed
# - Required event parameter was removed or changed to optional
# - Parameter type has changed.
#
#
# For the parameters with composite types the above checks are also applied
# recursively to every property of the type.
#
Expand Down Expand Up @@ -197,7 +197,7 @@ def extract_type(typed_object, types_map, errors):
ref = typed_object["$ref"]
if not ref in types_map:
errors.append("Can not resolve type: %s" % ref)
types_map[ref] = { "id": "<transient>", "type": "object" }
types_map[ref] = { "id": "<transient>", "type": "object" }
return types_map[ref]


Expand Down
1 change: 1 addition & 0 deletions deps/v8_inspector/platform/v8_inspector/InjectedScriptNative.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,4 @@ String16 InjectedScriptNative::groupName(int objectId) const
}

} // namespace blink

2 changes: 1 addition & 1 deletion deps/v8_inspector/platform/v8_inspector/V8Compat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include <v8.h>

#if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 2)
#if V8_MAJOR_VERSION < 5 || (V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION < 1)
namespace v8 {

// In standalone V8 inspector this is expected to be noop anyways...
Expand Down