doc: Rectify error in repl defineCommand tutorial #7365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
akki
force-pushed
the
repl-doc
branch
3 times, most recently
from
dc7bb4a
to
87452ab
Compare
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
| @@ -312,12 +312,12 @@ replServer.defineCommand('sayhello', { | |||
| action: function(name) { | |||
| this.lineParser.reset(); | |||
| this.bufferedCommand = ''; | |||
| this.write(`Hello, ${name}!\n`); | |||
| console.log(`Hello, ${name}!\n`); | |||
There was a problem hiding this comment.
both should not have the '\n' when using console.
There was a problem hiding this comment.
Updated PR accordingly.
|
Please let me know if there's anything else I can do to help getting this issue closed. Thanks. |
|
@cjihrig Did you merge this with the github merge button? The |
|
Yes, I did. |
|
okay, good to know that that can happen |
Fishrock123
pushed a commit
that referenced
this pull request
Jun 27, 2016
Fixes: #7357 PR-URL: #7365 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
Fixes: #7357 PR-URL: #7365 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, repl
Description of change
Fixes: #7357