build: split CI rules in Makefile #7317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaocgreis
added
build
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
Is the CI going to be back-compat so that older versions can still be tested if need be? |
|
@Fishrock123 |
| $(PYTHON) ./configure $(CONFIG_FLAGS) | ||
| $(MAKE) | ||
|
|
||
| run-ci: |
|
LGTM |
|
@Fishrock123 LGTY? |
|
Will land tomorrow and make the necessary adjustments in CI over the weekend, if there are no objections. |
| CI_NATIVE_SUITES := addons | ||
| CI_JS_SUITES := doctool known_issues message parallel pseudo-tty sequential | ||
|
|
||
| test-ci-native: | test/addons/.buildstamp |
There was a problem hiding this comment.
build-addons triggers compilation of the node executable. This cannot happen because this target will run on the test machine, after the cross-compiled binary is unpacked, and make will recompile everything.
|
LGTM with a question |
Some CI jobs compile Node and run the tests on different machines. This change enables collaborators to have finer control over what runs on these jobs, such as the exact suites to run. The test-ci rule was split into js and native, to allow for addons to be compiled only on the machines that are going to run them.
joaocgreis
force-pushed
the
joaocgreis-G6F-ci-targets
branch
from
e33a24b
to
0b041f6
Compare
|
Rebased and added a commit with comments for the new test targets. |
|
lgtm and 👍 on immediate backporting to |
joaocgreis
added a commit
that referenced
this pull request
Jul 2, 2016
Some CI jobs compile Node and run the tests on different machines. This change enables collaborators to have finer control over what runs on these jobs, such as the exact suites to run. The test-ci rule was split into js and native, to allow for addons to be compiled only on the machines that are going to run them. Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rod Vagg <[email protected]> PR-URL: #7317
joaocgreis
added a commit
that referenced
this pull request
Jul 2, 2016
Some CI jobs compile Node and run the tests on different machines. This change enables collaborators to have finer control over what runs on these jobs, such as the exact suites to run. The test-ci rule was split into js and native, to allow for addons to be compiled only on the machines that are going to run them. Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rod Vagg <[email protected]> PR-URL: #7317
|
One last CI: https://ci.nodejs.org/job/node-test-pull-request/3103/ Did not land in v0.x staging branches because those versions are not tested on ARM. |
|
Adjusted CI to use the new targets. Test runs: |
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
Some CI jobs compile Node and run the tests on different machines. This change enables collaborators to have finer control over what runs on these jobs, such as the exact suites to run. The test-ci rule was split into js and native, to allow for addons to be compiled only on the machines that are going to run them. Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rod Vagg <[email protected]> PR-URL: #7317
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2016
Some CI jobs compile Node and run the tests on different machines. This change enables collaborators to have finer control over what runs on these jobs, such as the exact suites to run. The test-ci rule was split into js and native, to allow for addons to be compiled only on the machines that are going to run them. Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rod Vagg <[email protected]> PR-URL: #7317
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Some CI jobs compile Node and run the tests on different machines. This change enables collaborators to have finer control over what runs on these jobs, such as the exact suites to run. The test-ci rule was split into js and native, to allow for addons to be compiled only on the machines that are going to run them. Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rod Vagg <[email protected]> PR-URL: #7317
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
build
Description of change
Some CI jobs compile Node and run the tests on different machines. This change enables collaborators to have finer control over what runs on these jobs, such as the exact suites to run. The test-ci rule was split into js and native, to allow for addons to be compiled only on the machines that are going to run them.
CI run for this change: https://ci.nodejs.org/view/All/job/node-test-commit/3754/
CI run of updated binary ARM job: https://ci.nodejs.org/view/All/job/reis-test-binary-arm/1/
This adds
doctool,known_issuesandpseudo-ttytest suites.No change is needed for Windows, since the current
vcbuildis usable by the Windows fanned job.*-stagingbranches. Is that ok?cc @nodejs/jenkins-admins @nodejs/build @nodejs/testing