Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: reduce implementation in header #7228

Closed
wants to merge 1 commit into from
Closed

inspector: reduce implementation in header #7228

wants to merge 1 commit into from

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Jun 8, 2016

Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

inspector

Description of change

This is needed to reduce the coupling between node files that use
node::Environment and inspector class.

Fixes: #7080

@ofrobots ofrobots added the inspector Issues and PRs related to the V8 inspector protocol label Jun 8, 2016
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 8, 2016
@bnoordhuis
Copy link
Member

LGTM

@ofrobots
inspector: reduce implementation in header
f2ce8da 
This is needed to reduce the coupling between node files that use
node::Environment and inspector class.

Fixes: nodejs#7080
@ofrobots
Copy link
Contributor Author

ofrobots commented Jun 9, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2966/

ofrobots pushed a commit that referenced this pull request Jun 10, 2016
@ofrobots
inspector: reduce implementation in header
624734e 
This is needed to reduce the coupling between node files that use
node::Environment and inspector class.

Fixes: #7080
PR-URL: #7228
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
@ofrobots
Copy link
Contributor Author

Thanks landed as 624734e.

@ofrobots ofrobots closed this Jun 10, 2016
@MylesBorins MylesBorins added this to the 7.0.0 milestone Jun 14, 2016
@MylesBorins MylesBorins mentioned this pull request Jun 14, 2016
Closed
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
@Fishrock123
inspector: reduce implementation in header
7da8a41 
This is needed to reduce the coupling between node files that use
node::Environment and inspector class.

Fixes: #7080
PR-URL: #7228
Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>

 Conflicts:
	src/node.cc
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

New Failures in AIX nightly run (possibly v8_inspector change)
5 participants
@ofrobots @bnoordhuis @MylesBorins @Fishrock123 @nodejs-github-bot