Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR 6575 #7128

Closed
wants to merge 1 commit into from
Closed

Backport PR 6575 #7128

wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 3, 2016
@santigimeno
Copy link
Member Author

Refs: #6575.

@santigimeno santigimeno mentioned this pull request Jun 3, 2016
Closed
2 tasks
@santigimeno
test: fix test-process-exec-argv flakiness
8d1d780 
Wait for the `close` event before parsing the child stdout output.

Fixes: nodejs#6480
Ref: nodejs#6575
PR-URL: nodejs#7128
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@santigimeno
Copy link
Member Author

PR updated with correct metadata

@MylesBorins MylesBorins self-assigned this Jun 3, 2016
@bnoordhuis
Copy link
Member

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Jun 3, 2016

LGTM

MylesBorins pushed a commit that referenced this pull request Jun 4, 2016
@santigimeno @MylesBorins
test: fix test-process-exec-argv flakiness
8f55108 
Wait for the `close` event before parsing the child stdout output.

Fixes: #6480
Ref: #6575
PR-URL: #7128
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 8f55108

@MylesBorins MylesBorins closed this Jun 4, 2016
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@santigimeno
test: fix test-process-exec-argv flakiness
ab50e82 
Wait for the `close` event before parsing the child stdout output.

Fixes: #6480
Ref: #6575
PR-URL: #7128
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@santigimeno
test: fix test-process-exec-argv flakiness
b4b5c54 
Wait for the `close` event before parsing the child stdout output.

Fixes: #6480
Ref: #6575
PR-URL: #7128
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@santigimeno santigimeno deleted the backport_1 branch July 27, 2016 14:21
@MylesBorins MylesBorins removed their assignment Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@santigimeno @bnoordhuis @jasnell @MylesBorins @nodejs-github-bot