benchmark: allow compare via fine-grained filters #711
Conversation
| @@ -21,8 +23,14 @@ for (var i = 2; i < process.argv.length; i++) { | |||
| case '-h': case '-?': case '--help': | |||
| console.log(usage); | |||
| process.exit(0); | |||
| case '--': | |||
| benchmarks = [] | |||
mscdex
force-pushed
the
enhance-bench-compare
branch
from
c63d3f8
to
26749db
Compare
|
I like this :]. LGTM |
| default: | ||
| nodes.push(arg); | ||
| if (benchmarks !== undefined) |
There was a problem hiding this comment.
This is splitting hairs, but can you make this Array.isArray(benchmarks)
|
Two small comments. Other than that, LGTM |
Before this commit, only benchmark targets defined in Makefile could be used. This commit allows execution of common.js directly and passing of filter arguments directly, allowing you to run either a subset of benchmarks or a single specific benchmark for comparison.
mscdex
force-pushed
the
enhance-bench-compare
branch
from
26749db
to
4f89fc1
Compare
|
Done. |
|
|
||
| var show = 'both'; | ||
| var nodes = []; | ||
| var html = false; | ||
| var benchmarks; |
There was a problem hiding this comment.
Shouldn't [testFilter] and benchmarks be options?
https://github.com/iojs/io.js/blob/v1.x/benchmark/common.js#L62
There was a problem hiding this comment.
I'm not sure what you mean. AFAIK using require('./common').createBenchmark() won't work well because it spawns tests with stdio: 'inherit', so you can't capture the output needed for comparing.
There was a problem hiding this comment.
Clarified via irc that it is using the naming found in https://github.com/iojs/io.js/blob/v1.x/benchmark/common.js#L10-L37
|
LGTM other than that the naming is a little confusing. Edit: Looks like that may be for another issue. |
Before this commit, only benchmark targets defined in Makefile could be used. This commit allows execution of common.js directly and passing of filter arguments directly, allowing you to run either a subset of benchmarks or a single specific benchmark for comparison. PR-URL: #711 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Before this commit, only benchmark targets defined in Makefile could be used. This commit allows execution of common.js directly and passing of filter arguments directly, allowing you to run either a subset of benchmarks or a single specific benchmark for comparison.