-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix mkdtemp example by removing hyphen #6834
Conversation
The example uses only `/tmp`, not `/tmp-`. So, the result cannot be `/tmp-abc123`, but just `/tmpabc123`.
Per: #6142 Clarify the prefix argument. Fixes: #6142 PR-URL: #6800 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
LGTM |
LGTM! Thank you!
|
LGTM |
The example uses only `/tmp`, not `/tmp-`. So, the result cannot be `/tmp-abc123`, but just `/tmpabc123`. PR-URL: #6834 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Landed in acc1142 |
The example uses only `/tmp`, not `/tmp-`. So, the result cannot be `/tmp-abc123`, but just `/tmpabc123`. PR-URL: #6834 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
The example uses only `/tmp`, not `/tmp-`. So, the result cannot be `/tmp-abc123`, but just `/tmpabc123`. PR-URL: #6834 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Checklist
Affected core subsystem(s)
doc
Description of change
The example uses only
/tmp
, not/tmp-
. So, the result cannot be/tmp-abc123
, but just/tmpabc123
.cc @jasnell