Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ensure test-npm-install uses correct node #6658

Merged
merged 1 commit into from
May 11, 2016
Merged

test: ensure test-npm-install uses correct node #6658

merged 1 commit into from
May 11, 2016

Commits on May 11, 2016

  1. test: ensure test-npm-install uses correct node 

    Currently it is possible that the shelled out instance of npm will use
the system copy of node. This PR changes the test to shim the build
directory into the path. This will ensure that npm will use the correct
version of node.

fixes: nodejs#6648

PR-URL: nodejs#6658
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
    Myles Borins committed May 11, 2016
    Configuration menu
    Copy the full SHA
    738a1d6 View commit details
    Browse the repository at this point in the history