Skip to content

typings: wire up spawn_sync internal binding types #65996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Sep 27, 2026
Merged

typings: wire up spawn_sync internal binding types #65996

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d4f5f0
typings: wire up spawn_sync internal binding types
agape1225 Sep 12, 2026
e87dfff
typings: widen spawn_sync option types to match implementation
agape1225 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions typings/globals.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import { ProfilerBinding } from './internalBinding/profiler';
import { SeaBinding } from './internalBinding/sea';
import { SerdesBinding } from './internalBinding/serdes';
import { SignalWrapBinding } from './internalBinding/signal_wrap';
import { SpawnSyncBinding } from './internalBinding/spawn_sync';
import { StreamPipeBinding } from './internalBinding/stream_pipe';
import { StringDecoderBinding } from './internalBinding/string_decoder';
import { SymbolsBinding } from './internalBinding/symbols';
Expand Down Expand Up @@ -84,6 +85,7 @@ interface InternalBindingMap {
sea: SeaBinding;
serdes: SerdesBinding;
signal_wrap: SignalWrapBinding;
spawn_sync: SpawnSyncBinding;
stream_pipe: StreamPipeBinding;
string_decoder: StringDecoderBinding;
symbols: SymbolsBinding;
Expand Down
33 changes: 33 additions & 0 deletions typings/internalBinding/spawn_sync.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
type SpawnSyncStdio =
| { type: 'ignore' }
| { type: 'pipe'; readable: boolean; writable: boolean; input?: Uint8Array }
| { type: 'inherit'; fd: number }
| { type: 'fd'; fd: number };

export interface SpawnSyncOptions {
file: string;
args: readonly string[];
cwd?: string | null;
envPairs?: readonly string[] | null;
uid?: number;
gid?: number;
detached?: boolean;
windowsHide?: boolean;
windowsVerbatimArguments?: boolean;
timeout?: number;
maxBuffer?: number;
killSignal?: number;
stdio: readonly SpawnSyncStdio[];
}

export interface SpawnSyncResult {
error?: number;
status: number | null;
signal: string | null;
output: (Uint8Array | null)[] | null;
pid: number;
}

export interface SpawnSyncBinding {
spawn(options: SpawnSyncOptions): SpawnSyncResult;
}
Loading