Skip to content

test_runner: display coverage errors in dot reporter #64695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elephant-y wants to merge 2 commits into from
+206 −0
Closed

test_runner: display coverage errors in dot reporter #64695

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d6261f
test_runner: display coverage errors in dot reporter
elephant-y Jul 23, 2026
837df80
test_runner: add coverage output test for dot reporter
elephant-y Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/internal/test_runner/reporter/dot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ module.exports = async function* dot(source) {
let count = 0;
let columns = getLineLength();
const failedTests = [];
const diagnosticErrors = [];
for await (const { type, data } of source) {
if (type === 'test:pass') {
yield `${colors.green}.${colors.reset}`;
Expand All @@ -18,6 +19,9 @@ module.exports = async function* dot(source) {
yield `${colors.red}X${colors.reset}`;
ArrayPrototypePush(failedTests, data);
}
if (type === 'test:diagnostic' && data.level === 'error') {
ArrayPrototypePush(diagnosticErrors, data.message);
}
Comment on lines +22 to +24

@avivkeller avivkeller Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to yield in place?

@elephant-y elephant-y Jul 24, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dot reporter is designed to be minimal — yielding diagnostic errors inline would break the dot grid alignment mid-run. This is the same pattern used by failedTests, which also collects and displays at the end rather than yielding inline. Keeping the output clean during the run, then showing errors after, is consistent with the dot reporter's philosophy.

if ((type === 'test:fail' || type === 'test:pass') && ++count === columns) {
yield '\n';

Expand All @@ -33,6 +37,12 @@ module.exports = async function* dot(source) {
yield formatTestReport('test:fail', test);
}
}
if (diagnosticErrors.length > 0) {
yield `\n${colors.red}Diagnostic errors:${colors.white}\n\n`;
for (const msg of diagnosticErrors) {
yield `${msg}\n`;
}
}
};

function getLineLength() {
Expand Down
Loading