stream: fix dropped first chunk in Utf8Stream buffer mode#63833
Merged
Conversation
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MattiasBuelens
approved these changes
Jun 10, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
trivikr
added
the
author ready
watilde
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 6e8c171 |
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Daijiro Wachi <daijiro.wachi@gmail.com> PR-URL: #63833 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In buffer content mode, #writeBuffer pushed an empty array when starting a new batch (including the very first write), so the data buffer was never stored while its length was still recorded in lens. The first write then emitted zero bytes and the misaligned bufs/lens queues crashed in mergeBuf() with a TypeError. Push [data] instead, matching the upstream sonic-boom implementation.