doc: update authors file #6373
doc: update authors file #6373
Conversation
jasnell
added
the
meta
| Ben Ripkens <[email protected]> | ||
| Ryan Sobol <[email protected]> | ||
| jona <[email protected]> | ||
| Anna Henningsen <[email protected]> |
There was a problem hiding this comment.
@jasnell You can remove this line, I feel fine being listed once, but thanks. 😄
|
done! removed a couple other duplicates that I noticed as well |
| Vitor Cortez <[email protected]> | ||
| Michael Theriot <[email protected]> | ||
| Peter Geiss <[email protected]> | ||
| Santiago Gimeno <[email protected]> |
There was a problem hiding this comment.
You can remove this entry. I'm already added with a different email, I committed only once with this by mistake.
|
@jasnell I think the dupes can be added to https://github.com/nodejs/node/blob/master/.mailmap |
| @@ -701,7 +701,6 @@ Mathias Küsel <[email protected]> | |||
| Qasim Zaidi <[email protected]> | |||
| Sam Newman <[email protected]> | |||
| Zach Bruggeman <[email protected]> | |||
| Michaël Zasso <[email protected]> | |||
There was a problem hiding this comment.
Any reason for moving duplicates to the bottom? The list should be ordered, afaik, and this commit actually moves some contributors down.
|
Thanks! Additional cleanups pushed. Keep the fixes coming! :-) |
| @@ -831,7 +831,6 @@ Claudio Rodriguez <[email protected]> | |||
| Ido Ben-Yair <[email protected]> | |||
| Kyle Smith <[email protected]> | |||
| Marti Martz <[email protected]> | |||
| Stefan Budeanu <[email protected]> | |||
There was a problem hiding this comment.
Same: moved for some reason to Stefan Budeanu <[email protected]> a bit lower.
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
7da4fd4 to
c7066fb
Compare
| Hideki Yamamura <[email protected]> | ||
| Lenny Markus <[email protected]> | ||
| Nelson Pecora <[email protected]> | ||
| Xotic750 <xotic750@gmail> |
There was a problem hiding this comment.
GitHub profile says Graham Fairweather. Also, the email is incorrect (misses the .com).
/cc @Xotic750
| Andrea Giammarchi <[email protected]> | ||
| Lance Ball <[email protected]> | ||
| Jarrett Widman <[email protected]> | ||
| Florian MARGAINE <[email protected]> |
There was a problem hiding this comment.
Should probably be Florian Margaine? @ralt
There was a problem hiding this comment.
I like the capitalized (and not uppercased) version better, but I don't really care either way tbh
There was a problem hiding this comment.
@jasnell That means that this line should be fixed to Florian Margaine.
Ah, sorry, it's already fixed =). Thanks!
|
Updated and squashed. Will be landing this shortly. Last call for additional edits. |
| Ilya Shaisultanov <[email protected]> | ||
| James Lal <[email protected]> | ||
| Josh Leder <[email protected]> | ||
| surya panikkal <[email protected]> |
There was a problem hiding this comment.
/cc @suryagh. Is that the preferred name?
|
Will be landing this in about twenty minutes or so |
|
LGTM |
|
Wait, give me two more minutes. |
| Craig Akimoto <[email protected]> | ||
| Michael Barrett <[email protected]> | ||
| Alexander Marchenko <[email protected]> | ||
| Steve Mao <[email protected]> |
There was a problem hiding this comment.
Steve Mao <[email protected]>
Steve Mao <[email protected]>
Duplicates?
|
@jasnell I highlighted some new entries that are likely duplicates. |
~116 new contributors since this was last updated!
|
OK... updated and landing! |
~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <[email protected]>
|
Landed in a026cd0 |
~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <[email protected]>
~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <[email protected]>
~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <[email protected]>
~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Affected core subsystem(s)
meta
Description of change
Update the authors file for v6 ... ~119 new contributors since this was last updated!