deps: roll back http_parser to 2.3.0 #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, please follow up with the issue for fixing it. |
Commit 598efcb ("deps: update http_parser to 2.4.1") introduced a regression in HTTP Upgrade header handling. Fixes: nodejs#627 PR-URL: nodejs#628 Reviewed-By: Fedor Indutny <[email protected]>
Add a regression test for nodejs#627. Before the http_parser rollback to 2.3.0, the request callback was called but an 'upgrade' event was not emitted, even though there is an Upgrade header present in the request. PR-URL: nodejs#628 Reviewed-By: Fedor Indutny <[email protected]>
bnoordhuis
force-pushed
the
fix-issue-627
branch
from
4a0405b to
24bd4e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 598efcb ("deps: update http_parser to 2.4.1") introduced a
regression in HTTP Upgrade header handling.
Fixes: iojs#627
R=@indutny