Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FIPS regression in 4.x #6110

Closed
wants to merge 1 commit into from
Closed

fix FIPS regression in 4.x #6110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/_tls_wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,13 @@ const defaultSessionIdContext = getDefaultSessionIdContext();
function getDefaultSessionIdContext() {
var defaultText = process.argv.join(' ');
/* SSL_MAX_SID_CTX_LENGTH is 128 bits */
if (process.config.variables.openssl_fips) {
if (
process.config &&
'variables' in process.config &&
process.config.variables &&
'openssl_fips' in process.config.variables &&
process.config.variables.openssl_fips
) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can simply be:

if (process.config && process.config.variables && process.config.variables.openssl_fips)

Using the in syntax is not common in core.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback! will update now.

FWIW I was guarding against the case where they are truthy but perhaps not an object (lacking the required attribute).

return crypto.createHash('sha1')
.update(defaultText)
.digest('hex').slice(0, 32);
Expand Down