deps: backport 125ac66 from v8 upstream #6086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested in nodejs#5221 Original commit message: fix debug command processor wrt restart frame. [email protected] BUG=v8:4757 LOG=N Review URL: https://codereview.chromium.org/1700693002 Cr-Commit-Position: refs/heads/master@{nodejs#33983}
MylesBorins
added
v8 engine
|
ci: https://ci.nodejs.org/job/node-test-pull-request/2182/ /cc @mhdawson you were working on a CI job for running the v8 suite right? |
|
Looks like ci failures are infra related... single arm box, all failures due to a port not being available /cc @nodejs/v8 |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Apr 7, 2016
As requested in #5221 Original commit message: fix debug command processor wrt restart frame. [email protected] BUG=v8:4757 LOG=N Review URL: https://codereview.chromium.org/1700693002 Cr-Commit-Position: refs/heads/master@{#33983} PR-URL: #6086 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 937ac37 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2016
As requested in #5221 Original commit message: fix debug command processor wrt restart frame. [email protected] BUG=v8:4757 LOG=N Review URL: https://codereview.chromium.org/1700693002 Cr-Commit-Position: refs/heads/master@{#33983} PR-URL: #6086 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
As requested in #5221 Original commit message: fix debug command processor wrt restart frame. [email protected] BUG=v8:4757 LOG=N Review URL: https://codereview.chromium.org/1700693002 Cr-Commit-Position: refs/heads/master@{#33983} PR-URL: #6086 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
As requested in #5221 Original commit message: fix debug command processor wrt restart frame. [email protected] BUG=v8:4757 LOG=N Review URL: https://codereview.chromium.org/1700693002 Cr-Commit-Position: refs/heads/master@{#33983} PR-URL: #6086 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
As requested in #5221 Original commit message: fix debug command processor wrt restart frame. [email protected] BUG=v8:4757 LOG=N Review URL: https://codereview.chromium.org/1700693002 Cr-Commit-Position: refs/heads/master@{#33983} PR-URL: #6086 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 3, 2016
As requested in #5221 Original commit message: fix debug command processor wrt restart frame. [email protected] BUG=v8:4757 LOG=N Review URL: https://codereview.chromium.org/1700693002 Cr-Commit-Position: refs/heads/master@{#33983} PR-URL: #6086 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 6, 2016
As requested in #5221 Original commit message: fix debug command processor wrt restart frame. [email protected] BUG=v8:4757 LOG=N Review URL: https://codereview.chromium.org/1700693002 Cr-Commit-Position: refs/heads/master@{#33983} PR-URL: #6086 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
As requested in #5221 Original commit message: fix debug command processor wrt restart frame. [email protected] BUG=v8:4757 LOG=N Review URL: https://codereview.chromium.org/1700693002 Cr-Commit-Position: refs/heads/master@{#33983} PR-URL: #6086 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this pull request
May 25, 2016
As requested in nodejs#5221 Original commit message: fix debug command processor wrt restart frame. [email protected] BUG=v8:4757 LOG=N Review URL: https://codereview.chromium.org/1700693002 Cr-Commit-Position: refs/heads/master@{#33983} PR-URL: nodejs/node#6086 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deps: backport 125ac66 from v8 upstream
As requested in #5221
Original commit message: