Skip to content

node-api: napi_set_prototype function #60711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 11 commits into from
Jan 2, 2026
Merged

node-api: napi_set_prototype function #60711

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
80ab216
node-api: add napi_set_prototype
siaeyy Nov 14, 2025
b5289ec
test: add test for napi_set_prototype
siaeyy Nov 14, 2025
ecfa19e
node-api: fix wrong node_api prefix
siaeyy Nov 14, 2025
e1b57e8
node-api: guard experimental node_api_set_prototype
siaeyy Nov 14, 2025
4dd9b55
doc: add node_api_set_prototype API
siaeyy Nov 15, 2025
fd9115f
test: define NAPI_EXPERIMENTAL for js-native-api test
siaeyy Nov 18, 2025
bed9864
test: fix the prefix of node_api_set_prototype
siaeyy Nov 18, 2025
dcc2192
fix: wrong set_prototype prefix
siaeyy Dec 2, 2025
94a2221
fix: use node_api_nogc_env instead of napi_env
siaeyy Dec 2, 2025
83a2e50
test: schedule the finalizer for not running while gc
siaeyy Dec 2, 2025
68b5a9e
style: format c++ source
siaeyy Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/js_native_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@ NAPI_EXTERN napi_status NAPI_CDECL napi_coerce_to_string(napi_env env,
napi_value* result);

// Methods to work with Objects
NAPI_EXTERN napi_status NAPI_CDECL napi_set_prototype(napi_env env,
Comment thread
siaeyy marked this conversation as resolved.
Outdated
Comment thread
siaeyy marked this conversation as resolved.
Outdated
Comment thread
siaeyy marked this conversation as resolved.
Outdated
Comment thread
siaeyy marked this conversation as resolved.
Outdated
napi_value object,
napi_value value);
Comment thread
siaeyy marked this conversation as resolved.
Outdated
NAPI_EXTERN napi_status NAPI_CDECL napi_get_prototype(napi_env env,
napi_value object,
napi_value* result);
Expand Down
20 changes: 20 additions & 0 deletions src/js_native_api_v8.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1567,6 +1567,26 @@ napi_status NAPI_CDECL napi_strict_equals(napi_env env,
return GET_RETURN_STATUS(env);
}

napi_status NAPI_CDECL napi_set_prototype(napi_env env,
Comment thread
siaeyy marked this conversation as resolved.
Outdated
napi_value object,
napi_value value) {
NAPI_PREAMBLE(env);
CHECK_ARG(env, value);

v8::Local<v8::Context> context = env->context();
v8::Local<v8::Object> obj;

CHECK_TO_OBJECT(env, context, obj, object);

v8::Local<v8::Value> val = v8impl::V8LocalValueFromJsValue(value);

v8::Maybe<bool> set_maybe = obj->SetPrototypeV2(context, val);

RETURN_STATUS_IF_FALSE_WITH_PREAMBLE(
env, set_maybe.FromMaybe(false), napi_generic_failure);
return GET_RETURN_STATUS(env);
}

napi_status NAPI_CDECL napi_get_prototype(napi_env env,
napi_value object,
napi_value* result) {
Expand Down
6 changes: 6 additions & 0 deletions test/js-native-api/test_general/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,18 @@ class ExtendedClass extends BaseClass {

const baseObject = new BaseClass();
const extendedObject = new ExtendedClass();
const nullProtoObject = { __proto__: null };
Comment thread
siaeyy marked this conversation as resolved.

// Test napi_strict_equals
assert.ok(test_general.testStrictEquals(val1, val1));
assert.strictEqual(test_general.testStrictEquals(val1, val2), false);
assert.ok(test_general.testStrictEquals(val2, val3));

// Test napi_set_prototype
test_general.testSetPrototype(nullProtoObject, Object.prototype);
assert.strictEqual(Object.getPrototypeOf(nullProtoObject),
Object.prototype);

// Test napi_get_prototype
assert.strictEqual(test_general.testGetPrototype(baseObject),
Object.getPrototypeOf(baseObject));
Expand Down
11 changes: 11 additions & 0 deletions test/js-native-api/test_general/test_general.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@ static napi_value testStrictEquals(napi_env env, napi_callback_info info) {
return result;
}

static napi_value testSetPrototype(napi_env env, napi_callback_info info) {
size_t argc = 2;
napi_value args[2];
NODE_API_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));

NODE_API_CALL(env, napi_set_prototype(env, args[0], args[1]));
Comment thread
siaeyy marked this conversation as resolved.
Outdated

return NULL;
}

static napi_value testGetPrototype(napi_env env, napi_callback_info info) {
size_t argc = 1;
napi_value args[1];
Expand Down Expand Up @@ -287,6 +297,7 @@ EXTERN_C_START
napi_value Init(napi_env env, napi_value exports) {
napi_property_descriptor descriptors[] = {
DECLARE_NODE_API_PROPERTY("testStrictEquals", testStrictEquals),
DECLARE_NODE_API_PROPERTY("testSetPrototype", testSetPrototype),
DECLARE_NODE_API_PROPERTY("testGetPrototype", testGetPrototype),
DECLARE_NODE_API_PROPERTY("testGetVersion", testGetVersion),
DECLARE_NODE_API_PROPERTY("testNapiRun", testNapiRun),
Expand Down