Skip to content

tools: fix linter for semver-major release proposals #60481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2025
+3 −2
Merged

tools: fix linter for semver-major release proposals #60481

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4330180
tools: fix linter for semver-major release proposals
aduh95 Oct 29, 2025
28ebe0e
fixup! tools: fix linter for semver-major release proposals
aduh95 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/actions/lint-release-proposal-commit-list.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@
let commitList;
if (commitListingStart === -1) {
// We're preparing a semver-major release.
commitList = changelog.replace(/(^.+\n### Semver-Major|\n### Semver-(Minor|Patch)) Commits\n/gs, '')
.replaceAll('**(SEMVER-MAJOR)** ', '');
assert.match(changelog, /\n### Semver-Major Commits\n/)

Check failure on line 26 in tools/actions/lint-release-proposal-commit-list.mjs

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Missing semicolon
// The proposal should contain only the release commit.
commitList = '';
} else {
const commitListingEnd = changelog.indexOf('\n\n<a', commitListingStart);
assert.notStrictEqual(commitListingEnd, -1);
Expand Down
Loading