Skip to content

http2: add diagnostics channels for client stream request body #60480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

http2: add diagnostics channels for client stream request body #60480

wants to merge 3 commits into from
+331 −0

Conversation

@RaisinTen
Copy link
Member

@RaisinTen RaisinTen commented Oct 29, 2025 •
edited
Loading

These would allow inspection of HTTP/2 client stream request bodies.

This is needed for #60483.

@RaisinTen
http2: add diagnostics channels for client stream request body
939ecff 
These would allow inspection of HTTP/2 client stream request bodies.

Signed-off-by: Darshan Sen <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 29, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov
Copy link

codecov bot commented Oct 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.58%. Comparing base (ba7cdf4) to head (be4f77d).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60480      +/-   ##
==========================================
+ Coverage   88.56%   88.58%   +0.02%     
==========================================
  Files         704      704              
  Lines      207774   207873      +99     
  Branches    40027    40063      +36     
==========================================
+ Hits       184020   184153     +133     
+ Misses      15800    15761      -39     
- Partials     7954     7959       +5
Files with missing lines Coverage Δ
lib/internal/http2/core.js 95.22% <100.00%> (+0.01%) ⬆️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen mentioned this pull request Oct 29, 2025
Open
IlyasShabi
IlyasShabi reviewed Oct 29, 2025
View reviewed changes
@RaisinTen
http2: preserve original chunk type
f592356 
Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen
doc: fix doc
be4f77d 
Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen RaisinTen requested a review from IlyasShabi October 31, 2025 18:14
IlyasShabi
IlyasShabi approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@IlyasShabi IlyasShabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Qard
Qard reviewed Oct 31, 2025
View reviewed changes
Copy link
Member

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one concern about this breaking API surface, but otherwise LGTM.

@RaisinTen RaisinTen requested a review from Qard November 1, 2025 07:05
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69990/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes

@IlyasShabi IlyasShabi IlyasShabi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RaisinTen @nodejs-github-bot @Qard @IlyasShabi