test: split test-runner-watch-mode-kill-signal #60298
Merged
+150
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has been timing out in the CI with no information about why. Splitting it into multiple files to at least show which test case is timing out. Drive-by: name the test as test-watch-mode-kill-signal-* as the tests aren't testing the test runner and are just testing --watch-kill-signal.
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60298 +/- ##
==========================================
- Coverage 88.60% 88.56% -0.04%
==========================================
Files 704 704
Lines 208325 208421 +96
Branches 40041 40050 +9
==========================================
+ Hits 184581 184583 +2
- Misses 15797 15862 +65
- Partials 7947 7976 +29 🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
joyeecheung
added
request-ci
|
There was a TDZ issue for the Windows case in the skip helper, so it wasn't skipped correctly. Moved it to a dedicated file to avoid that. |
joyeecheung
force-pushed
the
split-test-runner-kill
branch
from
0ab3c1c to
3970ca9
Compare
pmarchini
approved these changes
Oct 18, 2025
MoLow
approved these changes
Oct 19, 2025
atlowChemi
approved these changes
Oct 19, 2025
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in da5df1d |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2025
This test has been timing out in the CI with no information about why. Splitting it into multiple files to at least show which test case is timing out. Drive-by: name the test as test-watch-mode-kill-signal-* as the tests aren't testing the test runner and are just testing --watch-kill-signal. PR-URL: #60298 Refs: #60297 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been timing out in the CI with no information about why. Splitting it into multiple files to at least show which test case is timing out.
Drive-by: name the test as test-watch-mode-kill-signal-* as the tests aren't testing the test runner and are just testing --watch-kill-signal.
Refs: #60297