-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
sqlite: make SQLTagStore.prototype.size a getter
#60246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
cjihrig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but all of the stylistic changes should really be made separately.
dabca78 to
3142319
Compare
I'm already half-addressing them de facto with the main change, but these can be spun out if desired. Edit: Spun out the other doc changes. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60246 +/- ##
==========================================
- Coverage 88.58% 88.56% -0.02%
==========================================
Files 704 704
Lines 207858 207857 -1
Branches 40054 40056 +2
==========================================
- Hits 184131 184090 -41
- Misses 15760 15806 +46
+ Partials 7967 7961 -6
🚀 New features to boost your workflow:
|
ff66727 to
a2eaaa0
Compare
Drive-by: make callback `args` parameter names consistent
a2eaaa0 to
a217a01
Compare
|
Rebased for #60474. |
As implemented,
.dband.capacityare getters, and.sizeis a callable method. There's no reason for this inconsistency, so change.sizeto a getter.Drive-by changes while making alterations to the class template: the
FunctionCallbackInfoparameter for SQLTagStore member functions was variably labelledargsorinfo, and wasn't consistent with the header either. Use the canonicalargs.