Skip to content

Conversation

Han5991
Copy link
Contributor

@Han5991 Han5991 commented Oct 12, 2025

Summary

  • Adds missing r.close() calls to 4 test cases in test/parallel/test-repl-multiline-navigation.js
  • Prevents resource leaks by properly cleaning up REPL instances after each test
  • Ensures test isolation and improves reliability in CI environments
image image

Test plan

  • Run the modified test file: ./node test/parallel/test-repl-multiline-navigation.js
  • Verify all tests pass without resource warnings
  • Run full REPL test suite: tools/test.py repl
  • Check for any memory leak indicators in test output

Adds missing REPL instance cleanup calls to prevent resource leaks
in test/parallel/test-repl-multiline-navigation.js. Each test now
properly closes the REPL instance after testing cursor navigation.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 12, 2025
@Han5991 Han5991 marked this pull request as ready for review October 12, 2025 08:07
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (f9fcc74) to head (57da92f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60226   +/-   ##
=======================================
  Coverage   88.56%   88.57%           
=======================================
  Files         704      704           
  Lines      208125   208125           
  Branches    40003    40009    +6     
=======================================
+ Hits       184332   184338    +6     
- Misses      15809    15815    +6     
+ Partials     7984     7972   -12     

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants