doc: clarify that __dirname is module local #6018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/documentation |
|
LGTM. |
|
LGTM |
1 similar comment
|
LGTM |
jasnell
added a commit
that referenced
this pull request
Apr 2, 2016
Fixes: #5525 PR-URL: #6018 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in c06824b |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 5, 2016
Fixes: #5525 PR-URL: #6018 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Apr 5, 2016
Closed
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 11, 2016
Fixes: #5525 PR-URL: #6018 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
doc
Description of change
Clarify the __dirname is module local.
Fixes: #5525