-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
lib: create util.log function #60116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60116 +/- ##
==========================================
- Coverage 88.45% 88.44% -0.02%
==========================================
Files 703 704 +1
Lines 207796 207947 +151
Branches 40021 40046 +25
==========================================
+ Hits 183806 183912 +106
- Misses 15977 16021 +44
- Partials 8013 8014 +1
🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
This has three problems:
- it can loose messages in certain exit circumstances (the system for adding this is already present, see #53239).
- it provides an odd dx where the messages are handled differently between development and production systems.
- util.format is faster than before but still problematic
I’m not convinced this is a good addition to Node.js, and we should focus on actually adding the log system #49296.
I agree and that was my suggestion actually 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
util.log
has been used so if we introduce as it it's will be a massive breaking change
https://nodejs.org/docs/latest/api/deprecations.html#DEP0059
I'll close this PR and contribute to #49296 instead. thanks for the reviews! |
hello everyone, last week we disscused this issues : #190,#60032, later we think related nodejs/performance this issue, and @RafaelGSS suggestion after I try create new util.log method for memory friendly log
this new log method : async buffering + batch writes provides