-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
doc: remove optional title prefixes #60087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove optional title prefixes #60087
Conversation
Commit Queue failed- Loading data for nodejs/node/pull/60087 ✔ Done loading data for nodejs/node/pull/60087 ----------------------------------- PR info ------------------------------------ Title doc: remove optional title prefixes (#60087) Author Aviv Keller <[email protected]> (@avivkeller) Branch avivkeller:companion-stricter-regexps -> nodejs:main Labels doc Commits 2 - doc: remove optional title prefixes - fixup! Committers 1 - avivkeller <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60087 Refs: https://github.com/nodejs/doc-kit/issues/378 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60087 Refs: https://github.com/nodejs/doc-kit/issues/378 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 01 Oct 2025 16:37:54 GMT ✔ Approvals: 4 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60087#pullrequestreview-3290133038 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/60087#pullrequestreview-3294830863 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/60087#pullrequestreview-3296262624 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/60087#pullrequestreview-3296690196 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 60087 From https://github.com/nodejs/node * branch refs/pull/60087/merge -> FETCH_HEAD ✔ Fetched commits as 79f199953177..a1754942fb82 -------------------------------------------------------------------------------- Auto-merging doc/api/util.md [main 34e6892d93] doc: remove optional title prefixes Author: avivkeller <[email protected]> Date: Wed Oct 1 12:34:53 2025 -0400 2 files changed, 3 insertions(+), 3 deletions(-) [main f90689a9a2] fixup! Author: avivkeller <[email protected]> Date: Wed Oct 1 12:40:29 2025 -0400 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- doc: remove optional title prefixeshttps://github.com/nodejs/node/actions/runs/18228246317 |
Landed in 0e942cc |
Ref: nodejs/doc-kit#378
Companion: nodejs/doc-kit#449
Removes 3 outlier titles, so that stricter RegExps can be used in doc-kit.