lib: optimize priority queue

[gurgunday]

Further improves performance and fixes leftover issues from my last PR

• Makes heap PACKED
• Forces V8 optimization when resizing
• Removes dead code

Benchmarks:

main

node % ./node benchmark/run.js --filter priority util

util/priority-queue.js
util/priority-queue.js n=100000: 6,676,867.584962973

branch

node % ./node benchmark/run.js --filter priority util

util/priority-queue.js
util/priority-queue.js n=100000: 6,854,890.535966754

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (79f1999) to head (f980885).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60039      +/-   ##
==========================================
+ Coverage   88.43%   88.45%   +0.01%     
==========================================
  Files         703      703              
  Lines      207805   207800       -5     
  Branches    40026    40022       -4     
==========================================
+ Hits       183780   183801      +21     
+ Misses      16012    15979      -33     
- Partials     8013     8020       +7     

Files with missing lines	Coverage Δ
lib/internal/priority_queue.js	100.00% <100.00%> (+0.80%)	⬆️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gurgunday]

node/lib/internal/priority_queue.js

Lines 28 to 32 in cff138c

	const pos = ++this.#size;
	heap[pos] = value;
	if (heap.length === pos)
	heap.length *= 2;

This was dead code before, the check never worked

Example coverage form another PR: https://app.codecov.io/gh/nodejs/node/pull/60060/blob/lib/internal/priority_queue.js?dropdown=coverage#L32

[BridgeAR]

Benchmark https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1737/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69438/

[gurgunday]

@aduh95 can you also take a look, I missed these in my last PR

[gurgunday]

@aduh95 PTAL, it's actually faster without the manual array resizing in modern node (V8 does it anyway)

So we just removed the dead code and made it packed (assigning to arr[length] keeps it packed)

[gurgunday]

@BridgeAR you can run the priority queue benchmark again by the way

This was faster for me locally

[aduh95]

Started a benchmark including the upcoming V8 update: https://github.com/aduh95/node/actions/runs/18221639411

EDIT: seems to be (significantly) faster across the board 🚀

[aduh95]

Can you update the commit message? I don't think this has anything to do with coverage, instead you can use something like lib: optimize priority queue.

[gurgunday]

Can you update the commit message? I don't think this has anything to do with coverage, instead you can use something like lib: optimize priority queue.

Done, originally the PR only removed the check that never worked, which did increase coverage, but then I added the perf improvement

[gurgunday]

I need a rerun of macOS and an approval

@aduh95

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69547/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69557/

[aduh95]

Landed in e978a63