Skip to content

src: improve performance of dotenv ToObject #60038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2025
Merged

src: improve performance of dotenv ToObject #60038

merged 1 commit into from
Oct 4, 2025
+29 −11

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 27, 2025

Improves the performance of the dotenv parser ToObject method. Also, switch to a null prototype object to avoid potential prototype pollution issues.

util/parse-env.js n=30000 *** 57.69 %  ±1.37% ±1.83% ±2.40%

semver-major because of the switch to the null prototype.

@jasnell
src: improve performance of dotenv ToObject
91028a8 
Improves the performance of the dotenv parser
ToObject method. Also, switch to a null prototype
object to avoid potential prototype pollution
issues.
@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 27, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Sep 27, 2025
gurgunday
gurgunday approved these changes Sep 27, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2025
@jasnell jasnell requested review from anonrig and mcollina September 27, 2025 20:49
@jasnell jasnell removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 27, 2025
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov Codecov

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69534/

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2025
@nodejs-github-bot nodejs-github-bot merged commit 10df38a into nodejs:main Oct 4, 2025
89 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 10df38a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@anonrig anonrig anonrig approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@mcollina mcollina Awaiting requested review from mcollina

+1 more reviewer

@gurgunday gurgunday gurgunday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell @nodejs-github-bot @addaleax @anonrig @marco-ippolito @gurgunday