module: fix directory option in the enableCompileCache() API #59931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
module
joyeecheung
force-pushed
the
fix-compile-cache-api
branch
from
a2251fa to
8fa6d26
Compare
The option name should be `directory` to be consistent with the returned result. It should also allow environment variable overrides. This also adds documentation for the new options and improves it.
joyeecheung
force-pushed
the
fix-compile-cache-api
branch
from
8fa6d26 to
9fe76e8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59931 +/- ##
==========================================
+ Coverage 88.23% 88.48% +0.24%
==========================================
Files 703 703
Lines 207393 207550 +157
Branches 39888 40013 +125
==========================================
+ Hits 183003 183645 +642
+ Misses 16346 15900 -446
+ Partials 8044 8005 -39
🚀 New features to boost your workflow:
|
Aditi-1400
reviewed
Sep 22, 2025
Co-authored-by: Aditi <[email protected]>
jsumners-nr
approved these changes
Sep 24, 2025
Aditi-1400
approved these changes
Oct 9, 2025
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in db0121b |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option name should be
directoryto be consistent with the returned result. It should also allow environment variable overrides.This also adds documentation for the new options and improves it.