module: handle null source from async loader hooks in sync hooks #59929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
joyeecheung
force-pushed
the
commonjs-source
branch
2 times, most recently
from
db791a0 to
64e35a5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59929 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 704 704
Lines 208081 208127 +46
Branches 40004 40022 +18
=======================================
+ Hits 184265 184310 +45
- Misses 15809 15827 +18
+ Partials 8007 7990 -17
🚀 New features to boost your workflow:
|
joyeecheung
force-pushed
the
commonjs-source
branch
from
64e35a5 to
ea58659
Compare
|
This is necessary to fix known issues with sync/async loader hook interop. Can I get some reviews please? @nodejs/loaders |
GeoffreyBooth
approved these changes
Sep 22, 2025
github-actions
bot
removed
the
request-ci
JakobJingleheimer
approved these changes
Sep 24, 2025
joyeecheung
force-pushed
the
commonjs-source
branch
from
ea58659 to
6ea04e7
Compare
This relaxes the validation in sync hooks so that it accepts the quirky nullish source returned by the default step of the async loader when the module being loaded is CommonJS. When there are no customization hooks registered, a saner synchronous default load step is used to use a property instead of a reset nullish source to signify that the module should go through the CJS monkey patching routes and reduce excessive reloading from disk.
joyeecheung
force-pushed
the
commonjs-source
branch
from
6ea04e7 to
b5663af
Compare
joyeecheung
force-pushed
the
commonjs-source
branch
from
b5663af to
790b5f4
Compare
|
Addressed the comments and CI is finally green. Can you take a look again? Thanks! @GeoffreyBooth @JakobJingleheimer |
JakobJingleheimer
approved these changes
Oct 13, 2025
github-actions
bot
removed
the
request-ci
GeoffreyBooth
approved these changes
Oct 14, 2025
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 170848b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes the validation in sync hooks so that it accepts the quirky nullish source returned by the default step of the async loader when the module being loaded is CommonJS. When there are no customization hooks registered, a saner synchronous default load step is used to use a property instead of a reset nullish source to signify that the module should go through the CJS monkey patching routes and reduce excessive reloading from disk.
Fixes: #59384
Fixes: #57327
Refs: #59666
Refs: https://github.com/dygabo/load_module_test