Skip to content

Benchmark/update configs to n #59872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Benchmark/update configs to n #59872

wants to merge 3 commits into from

Conversation

brunocroh
Copy link
Member

Normalize the benchmarks to use n whenever possible nodejs/performance#187

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. permission Issues and PRs related to the Permission Model util Issues and PRs related to the built-in util module. labels Sep 12, 2025
@RafaelGSS RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Sep 12, 2025
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69236/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69357/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2025
@nodejs-github-bot
Copy link
Collaborator

Landed in 4dc19ec...0817b40

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2025
@brunocroh @nodejs-github-bot
benchmark: update num to n in dgram offset-length
1e008da 
PR-URL: #59872
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2025
@brunocroh @nodejs-github-bot
benchmark: update count to n in permission startup
43007e3 
PR-URL: #59872
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2025
@brunocroh @nodejs-github-bot
benchmark: remove unused variable from util/priority-queue
0817b40 
PR-URL: #59872
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 6, 2025
@brunocroh @targos
benchmark: update num to n in dgram offset-length
3c8a609 
PR-URL: #59872
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 6, 2025
@brunocroh @targos
benchmark: update count to n in permission startup
0329425 
PR-URL: #59872
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 6, 2025
@brunocroh @targos
benchmark: remove unused variable from util/priority-queue
e8cff3d 
PR-URL: #59872
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dgram Issues and PRs related to the dgram subsystem / UDP. permission Issues and PRs related to the Permission Model util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brunocroh @nodejs-github-bot @lpinca @RafaelGSS @jasnell