punycode: update to 1.4.1 #5922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update punycode to the latest released version. This is mainly in order to further reduce the maintenance burden. In nodejs#1246 a fix introducing `new` to errors was introduced and it has since been ported back to the punycode library. This puts Node back in sync with the library itself so it can receive future fixes and updates directly. PR-URL: Reviewed-By: Reviewed-By:
|
I think we've been down this path before and didn't update because there are no meaningful changes here. -1 |
|
@cjihrig I also seem to recall that. |
|
Oh, ok. I just noticed it wasn't updated - I think I'll just leave punycode alone, everything I try to do with it is poorly received and no one is complaining about the bad performance or completely un node-like code anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
punycode
Description of change
Update punycode to the latest released version. This is mainly in order to reduce the maintenance burden. In #1246 a fix introducing
newto errors was introduced and it has since been ported back to the punycode library.This puts Node back in sync with the library itself so it can receive future fixes and updates directly.