Skip to content

benchmark: add fs warmup to writefile-promises #59215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

benchmark: add fs warmup to writefile-promises #59215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions benchmark/fs/writefile-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,17 @@ function main({ encodingType, duration, concurrent, size }) {
let writes = 0;
let waitConcurrent = 0;

const startedAt = Date.now();
const endAt = startedAt + (duration * 1000);
let startedAt = Date.now();
let endAt = startedAt + duration * 1000;

// fs warmup
for (let i = 0; i < concurrent; i++) write();

writes = 0;
waitConcurrent = 0;

startedAt = Date.now();
endAt = startedAt + duration * 1000;

bench.start();

Expand All @@ -59,7 +68,8 @@ function main({ encodingType, duration, concurrent, size }) {
}

function write() {
fs.promises.writeFile(`${filename}-${filesWritten++}`, chunk, encoding)
fs.promises
.writeFile(`${filename}-${filesWritten++}`, chunk, encoding)
.then(() => afterWrite())
.catch((err) => afterWrite(err));
}
Expand All @@ -72,7 +82,7 @@ function main({ encodingType, duration, concurrent, size }) {
writes++;
const benchEnded = Date.now() >= endAt;

if (benchEnded && (++waitConcurrent) === concurrent) {
if (benchEnded && ++waitConcurrent === concurrent) {
stop();
} else if (!benchEnded) {
write();
Expand Down
Loading